raidemulator: Fix invalid field mapping in AbilityExtra#919
Merged
valarnin merged 1 commit intoOverlayPlugin:mainfrom Jan 4, 2026
Merged
raidemulator: Fix invalid field mapping in AbilityExtra#919valarnin merged 1 commit intoOverlayPlugin:mainfrom
valarnin merged 1 commit intoOverlayPlugin:mainfrom
Conversation
github-actions
bot
added
needs-review
xiashtra
approved these changes
Jan 4, 2026
Collaborator
xiashtra
left a comment
xiashtra
left a comment
There was a problem hiding this comment.
Kind of wish we were always more explicit with naming ID fields everywhere (e.g., abilityId, sourceId, etc.) to help avoid errors like this.
Collaborator
Author
That's on my list of things to clean up, but it'll be a "breaking change" because all encounters already loaded into raidemulator will no longer be valid. |
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Jan 4, 2026
…ra (OverlayPlugin#919) As mentioned in OverlayPlugin#917, noticed this bug while testing. ed2a29a
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Jan 4, 2026
…ra (OverlayPlugin#919) As mentioned in OverlayPlugin#917, noticed this bug while testing. ed2a29a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #917, noticed this bug while testing.